Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing primary key in Jobs_history + option to disable feedback completely. #2457

Merged
merged 4 commits into from
Jun 8, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jun 8, 2024

  • Add missing primary key in jobs_history
  • Add option to disable feedback completely (and thus the request every 1s)

@ildyria ildyria changed the title Add missing primary key Add missing primary key in Jobs_history + option to disable feedback completely. Jun 8, 2024
@ildyria ildyria force-pushed the add-primary_key_jobs_history branch from 094ba9d to 2e5f8ff Compare June 8, 2024 11:51
@ildyria ildyria changed the title Add missing primary key in Jobs_history + option to disable feedback completely. 3 - Add missing primary key in Jobs_history + option to disable feedback completely. Jun 8, 2024
@ildyria ildyria changed the title 3 - Add missing primary key in Jobs_history + option to disable feedback completely. 4 - Add missing primary key in Jobs_history + option to disable feedback completely. Jun 8, 2024
@ildyria ildyria added this to the 5.3.1 milestone Jun 8, 2024
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jun 8, 2024
@ildyria ildyria changed the title 4 - Add missing primary key in Jobs_history + option to disable feedback completely. Add missing primary key in Jobs_history + option to disable feedback completely. Jun 8, 2024
@ildyria ildyria merged commit 59293f6 into remove-install-middleware Jun 8, 2024
10 checks passed
@ildyria ildyria deleted the add-primary_key_jobs_history branch June 8, 2024 18:31
ildyria added a commit that referenced this pull request Jun 8, 2024
* Add missing primary key in Jobs_history + option to disable feedback completely. (#2457)
* Wrap collections to avoid double queries (#2458)
ildyria added a commit that referenced this pull request Jun 8, 2024
* Remove middleware when we already passed the landing point (#2456)
* Add missing primary key in Jobs_history + option to disable feedback completely. (#2457)
* Wrap collections to avoid double queries (#2458)
ildyria added a commit that referenced this pull request Jun 8, 2024
* Composer update: add all the required annotations for phpstan
* Remove some queries. (#2455)
* Remove middleware when we already passed the landing point (#2456)
* Add missing primary key in Jobs_history + option to disable feedback completely. (#2457)
* Wrap collections to avoid double queries (#2458)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants